-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AI Transform Node): Support for drag and drop #11276
Conversation
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
…input-fields-dragging
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
…input-fields-dragging
border: 1.5px dashed var(--color-ndv-droppable-parameter) !important; | ||
} | ||
.activeDrop { | ||
border: 1.5px solid var(--color-success) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be done without !important ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we need to override defaults of N8nInput(ElInput)
@@ -227,7 +276,7 @@ onMounted(() => { | |||
|
|||
<style module lang="scss"> | |||
.input * { | |||
border: 0 !important; | |||
border: 1.5px transparent !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be done without !important ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we need to override defaults of N8nInput(ElInput)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
✅ All Cypress E2E specs passed |
n8n Run #8117
Run Properties:
|
Project |
n8n
|
Branch Review |
node-1863-input-fields-dragging
|
Run status |
Passed #8117
|
Run duration | 04m 40s |
Commit |
b26ccb0c91: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
|
Committer | Michael Kret |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
0
|
Skipped |
0
|
Passing |
478
|
View all changes introduced in this branch ↗︎ |
Got released with |
Summary
Allow dragging data pills from the input to insert the field name
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1863/input-fields-dragging